fix: Block path traversal attacks via the deployment API for MLflow-Triton - #8665
Merged
mudit-eng merged 9 commits intoMar 4, 2026
Conversation
mudit-eng
changed the title
Contributor
yinggeh
reviewed
Feb 18, 2026
yinggeh
reviewed
Feb 18, 2026
yinggeh
reviewed
Feb 18, 2026
yinggeh
reviewed
Feb 18, 2026
mudit-eng
changed the title
yinggeh
reviewed
Feb 20, 2026
| if flavor not in self.supported_flavors: | ||
| raise Exception("{} model flavor not supported by Triton".format(flavor)) | ||
|
|
||
| def _validate_model_name(self, name): |
Contributor
There was a problem hiding this comment.
Just a note no need to fix today, there are multiple similar pattern @whoisj added to address PSIRT issues in server. We could refactor them into one common utility fuction.
yinggeh
requested changes
Feb 20, 2026
yinggeh
reviewed
Feb 23, 2026
yinggeh
reviewed
Feb 27, 2026
yinggeh
requested changes
Feb 27, 2026
mudit-eng
deleted the
mudita/tri-665-psirt-triton-inference-server-mlflow-plugin-path-traversal
branch
March 4, 2026 17:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does the PR do?
This code change sanitizes the model name in the MLflow-Triton deployment plugin to prevent path traversal.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
Where should the reviewer start?
Test plan:
Added a unit test and verified locally. Also, tested in CI.
44324776, 45253345
Caveats:
Background
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)